[systemd-devel] [patch] build: do not touch CFLAGS

[Jan Engelhardt]

On Saturday 2012-01-07 05:39, Kay Sievers wrote:

>On Sat, Jan 7, 2012 at 04:34, Jan Engelhardt <jengelh at medozas.de> wrote:
>>
>> On Saturday 2012-01-07 02:22, Kay Sievers wrote:
>>>
>>>>  Furthermore,
>>>> it overrides per_target_CFLAGS, which is also undesired.
>>>
>>>Guess, we need a cleaner solution, this patch looks even more like a hack.
>>
>> From the rather sparse comment I suppose you wanted something like this
>> instead.
>
>> +++ b/m4/attributes.m4
>> @@ -71,7 +71,7 @@ AC_DEFUN([CC_CHECK_CFLAG_APPEND], [
>>   )
>>
>>   AS_IF([eval test x$]AS_TR_SH([cc_cv_cflags_$1])[ = xyes],
>> -    [CFLAGS="$CFLAGS $1"; DEBUG_CFLAGS="$DEBUG_CFLAGS $1"; $2], [$3])
>> +    [ac_extra_CFLAGS="$ac_extra_CFLAGS $1"; DEBUG_CFLAGS="$DEBUG_CFLAGS $1"; $2], [$3])
>
>Yeah, something like that. Not mangling CFLAGS= with the build-sys
>macros sounds much better.

So take this one in :)