[systemd-devel] [PATCH] add keyscript support to cryptsetup

[Lennart Poettering]

On Fri, 29.06.12 00:56, David Härdeman (david at hardeman.nu) wrote:

> Debian's cryptsetup package supports the keyscript= option in /etc/crypttab
> 
> This patch is a first attempt at implementing support for the same option
> in systemd. It is not at exact feature parity yet (environment variables
> are missing and relative paths are not supported), but it's a start.
> 
> I'm not sure if the (somewhat complicated dance) with fds is considered
> acceptable or if I should use something else?

Humpf. So I am really not convinced that supporting this is really such
a good idea. I am not a fan at all of this scriptlogic. (Starting with
the fact that this is called keyscript=, i.e. as if this really needs to
be a script...).

I wonder what the precise usecases for this are, and whether we can't
find better solutions for these usecases... I mean, we already have the
password agent logic, that is asynchronous, and way more powerful:

http://www.freedesktop.org/wiki/Software/systemd/PasswordAgents

Lennart

-- 
Lennart Poettering - Red Hat, Inc.