[systemd-devel] [PATCH] fstab-generator: avoid mangling mount source and dest

[Manuel Amador (Rudd-O)]

It will also break ZFS legacy mounts.

On Mon, 2012-06-04 at 08:04 -0400, Dave Reisner wrote:

> On Mon, Jun 04, 2012 at 12:57:47PM +0200, Kay Sievers wrote:
> > On Sun, Jun 3, 2012 at 4:18 AM, Dave Reisner <dreisner at archlinux.org> wrote:
> > > This can invalidate otherwise valid source paths with trailing slashes,
> > > such as "host:/" in the case of a network mount. We don't really have
> > > any business touching these anyway, since we'll just pass this to
> > > /bin/mount, which sanitizes the paths for us.
> > 
> > Changed it to use:
> >   path_is_absolute()
> > instead of:
> >   is_path(),
> > so that we still sanitize the input we might match against.
> > 
> > Let me know, if you think that could still cause any problems?
> > 
> > Thanks,
> > Kay
> 
> Yes, this will still break CIFS shares.
> _______________________________________________
> systemd-devel mailing list
> systemd-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20120712/4b51ef79/attachment.html>