[systemd-devel] [PATCH] use #pragma once instead of foo*foo #define guards

Cristian Rodríguez crrodriguez at opensuse.org
Wed Jul 18 16:24:47 PDT 2012


El 18/07/12 07:31, Lucas De Marchi escribió:
> On Wed, Jul 18, 2012 at 7:47 AM, Kay Sievers <kay at vrfy.org> wrote:
>> On Wed, Jul 18, 2012 at 12:39 PM, Lennart Poettering
>> <lennart at poettering.net> wrote:
>>> On Tue, 17.07.12 17:14, Shawn Landden (shawnlandden at gmail.com) wrote:
>>
>>> Hmm, so I am not completely opposed to this (though I also don't see the
>>> big benefit). But before we merge anything like this: I think the
>>> externally visible headers (i.e. the ones above) should really continue
>>> to use the classic #ifdef guards. For the externally used headers we
>>> should try hard to make them as "compatible" as we can. That includes
>>> the C++ external foo, but also not using any fancy C99 features or
>>> #pragmas.
>>>
>>> Kay, Michal, do you have any strong opinion on this?
>>
>> I don't care much.
>>
>> But I like the "experiment", it looks like a nice way doing that.
>> Sounds fine to me to try with all the internal stuff, but not the
>> libs.
> 
> I'd like to see this experiment, too. I'll probably do that to kmod
> and see what happens.

Nothing will happend, systemd is linux-only software and gcc, clang etc
all support this feature.



More information about the systemd-devel mailing list