[systemd-devel] [PATCH] use "Out of memory." consistantly (or with "\n")

shawn shawnlandden at gmail.com
Wed Jul 25 16:17:07 PDT 2012


On Wed, 2012-07-25 at 18:11 +0200, Lennart Poettering wrote: 
> On Wed, 25.07.12 11:24, Kay Sievers (kay at vrfy.org) wrote:
> > On Wed, Jul 25, 2012 at 6:12 AM, Shawn Landden <shawnlandden at gmail.com> wrote:
> > > glibc/glib both use "out of memory" consistantly so maybe we should
> > > consider that instead of this.
> > >
> > > Eliminates one string out of a number of binaries. Also fixes extra newline
> > > in udev/scsi_id
> > 
> > Applied.
> 
> Hmm, given that we might run into this again, it might make sense to
> define function for this? Maybe something like this in log.h?
> 
> static inline void log_oom(void) {
>        log_error("Out of memory.");
>        return -ENOMEM;
> }
> 
> Which we then could use everywhere?

patch that does that

-- 
-Shawn Landden
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-log.h-new-log_oom-int-ENOMEM-use-it.patch
Type: text/x-patch
Size: 65334 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20120725/2bf969e5/attachment-0001.bin>


More information about the systemd-devel mailing list