[systemd-devel] [PATCH 1/5] build-sys: move common libraries to separate Makefile

[Lennart Poettering]

On Tue, 12.06.12 12:52, William Hubbs (w.d.hubbs at gmail.com) wrote:

heya,

Sorry, not going to merge this. This patch is ugly, and I doubt you can
fix it to make it less ugly. Split makefiles suck [1], and so do makefiles
with even more ifdefs than we already have. Besides that it would
probably be the first package where you can disable building the main
component.

Feel free to maintain such a patch downstream, git makes that easy. But
I don't want to maintain that upstream. It makes my life harder, I'd
break it all the time without noticing and so it has no place upstream. 

The first rule for all maintainers is only to merge stuff they
themselves are willing to maintain. This is true for fringe patches, but
even more on core stuff like build system changes that are essential for
the whole package.

My recommendation for distros who want udev without the rest of systemd
is to build systemd normally and just pick the files you are interested
in from "make install". (And besides that, I am pretty sure you probably
want to pick at least tmpfiles in addition to udev from the build tree).

Sorry,

Lennart

Footnotes:

[1] I mean, seriously, we made the clear decision to have only a single
makefile and avoid recursive make and now with splitting this stuff up
you undo that half-way.

-- 
Lennart Poettering - Red Hat, Inc.