[systemd-devel] [PATCH] remount-fs: pass fstab options to mount

[Lennart Poettering]

On Mon, 25.06.12 13:56, richard.maw at codethink.co.uk (richard.maw at codethink.co.uk) wrote:

> From: Richard Maw <richard.maw at codethink.co.uk>
> 
> busybox's mount implementation doesn't re-read the options from
> the fstab, it uses the flags it has in mtab.
> This makes `mount -o remount $device` a no-op.
> 
> Rather than do string concatenation, add another -o option to the
> list of parameters, since -o is cumulative.

I think this should better be fixed in busybox, rather than worked
around in systemd.

I think it is a much better idea to have /bin/mount deal with the
the logic how to apply the options from fstab to the options known by
the kernel, than by doing a half-way attempt in systemd.

Sorry,

Lennart

-- 
Lennart Poettering - Red Hat, Inc.