[systemd-devel] PATCH: fix sparse warnings

[Lennart Poettering]

On Wed, 29.02.12 18:33, Frederic Crozat (fcrozat at suse.com) wrote:

> Le mercredi 29 février 2012 à 17:04 +0000, Frederic Crozat a écrit :
> > Hi, 
> > 
> > while trying to use sparse to detect potential endianness errors in
> > journald code (apparently, we can't use it for that), I found some other
> > warnings with sparse.
> > 
> > Attached patch fixes those (mostly missing static call, 0 vs NULL and
> > macros redefinition).
> 
> Better with patch attached ;)

> >From d07e3f17e21ad4b200d0e076e0f49a3f8e91fae9 Mon Sep 17 00:00:00 2001
> From: Frederic Crozat <fcrozat at suse.com>
> Date: Wed, 29 Feb 2012 14:42:49 +0100
> Subject: [PATCH] fix sparse warnings

Looks all good. Applied.

I have little experience with sparse, but iirc it knows decorators for
variables for le/be, right? Is this something we might want to use in
the journal to avoid LE/BE issues like those you tracked down?

Lennart

-- 
Lennart Poettering - Red Hat, Inc.