[systemd-devel] [PATCH] fsck: remove distro specific guards on forcefsck/fastboot

[Lennart Poettering]

On Sun, 18.03.12 23:20, Dave Reisner (d at falconindy.com) wrote:

> It's not really clear why these were guarded to begin with, but given
> that they're opt in, it doesn't really make much sense. Give everyone
> the benefit of these commandline parameters.

Hmm, they only exist for compat reasons with fedora/mandriva. We'd very
much prefer if distros which don't have this legacy would rather use
fsck.mode=auto/force/skip instead.

Did these options exist in arch before and is it important to keep
compat here? If not, then please use fsck.mode= instead.

> ---
> lest i send a patch to add '|| defined(TARGET_ARCH)' ...
> 
>  src/fsck.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/fsck.c b/src/fsck.c
> index d3ac83c..32b0981 100644
> --- a/src/fsck.c
> +++ b/src/fsck.c
> @@ -127,12 +127,10 @@ static int parse_proc_cmdline(void) {
>                          arg_skip = true;
>                  else if (startswith(w, "fsck.mode"))
>                          log_warning("Invalid fsck.mode= parameter. Ignoring.");
> -#if defined(TARGET_FEDORA) || defined(TARGET_MANDRIVA) || defined(TARGET_MAGEIA)
>                  else if (strneq(w, "fastboot", l))
>                          arg_skip = true;
>                  else if (strneq(w, "forcefsck", l))
>                          arg_force = true;
> -#endif
>          }
>  
>          free(line);


Lennart

-- 
Lennart Poettering - Red Hat, Inc.