[systemd-devel] [PATCH] Fix a fatal dbus abort in bus_manager_message_handler()

[Zbigniew Jędrzejewski-Szmek]

On 10/31/2012 02:09 PM, Colin Walters wrote:
> On Wed, 2012-10-31 at 13:53 +0100, Eelco Dolstra wrote:
> 
>> Oops, you're right.  Searching for calls to dbus_message_unref I mistook the
>> "oom" label in message_from_file_changes() for the one in
>> bus_manager_message_handler().  So this one should stay.
> 
> You could also add the cleanup attribute there too, and delete the
> unref.
> 
> Either way:
> 
> Reviewed-by: Colin Walters <walters at verbum.org>
Applied (with Colin's fix, the first one, using _cleanup_ is not possible,
because reply is only unref()ed in the error path).

Zbyszek