[systemd-devel] Error message for Accept=true and non-template service file

[Zbigniew Jędrzejewski-Szmek]

On Mon, Nov 19, 2012 at 11:17:13PM +0100, Thomas H.P. Andersen wrote:
> It is not very obvious what went wrong. Would it not make sense to
> detect the wrong service file type at socket start time? I could try
> to write a patch for that. (Any advice or pointers about where to best
> implement it would naturally be much appreciated)
Hi,

if I understand your words correctly you are implying that the *type*
is somehow wrong, but it's just a matter of a missing unit with
the required name (telnet at .service). So I'm guessing that the patch
should first try to print the name of the missing unit.

Second problem is that it would be nicer to detect the fact
that the template unit is missing when starting the socket
and error out immediately.

> [1] telnet bug: https://bugzilla.redhat.com/show_bug.cgi?id=737725

> Also the ExecStart should probably start with a '-' so information is
> not kept around for connection-specific failures.
We now have SuccessExitStatus=. I think it would be better (if telnetd
has enough fine-grained return codes to distinguish
not-really-failures) to use that instead.

Zbyszek