[systemd-devel] [PATCH] cgroup: look up user session units from cgroups as well.

[Lennart Poettering]

On Thu, 15.11.12 17:46, Mirco Tischler (mt-ml at gmx.de) wrote:

> 2012/11/15 Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl>
> 
> > On Tue, Nov 06, 2012 at 01:07:26AM +0100, Mirco Tischler wrote:
> > > This allows the journal code to set the _SYSTEMD_UNIT tag for messages
> > generated
> > > by systemd --user session units.
> > Hi,
> > this would open the door to spoofed messages. Previously Lennart
> > suggested [1] using _SYSTEMD_USER_UNIT=.
> >
> > Zbyszek
> >
> > [1]
> > http://lists.freedesktop.org/archives/systemd-devel/2012-August/006103.html
> 
> Hi,
> 
> thanks for your comment.
> My idea was to add filtering after the _SYSTEMD_SESSION field to systemctl
> status. The reason why I didn't implement this yet is because I wasn't sure
> about the best way to make known wether we are in session or system mode
> where we'd need it. But if _SYSTEMD_USER_UNIT is preferred, I'll try to
> implement a patch.

I think _SYSTEMD_USER_UNIT= would be the much nicer solution as it
avoids any misunderstands by default.

Otherwise the patch looked quite OK from a rough glance.

Lennart

-- 
Lennart Poettering - Red Hat, Inc.