[systemd-devel] 4 failing tests

[Kay Sievers]

On Fri, Nov 30, 2012 at 6:43 PM, Timothy Pepper
<timothy.c.pepper at linux.intel.com> wrote:
> On Fri 30 Nov at 13:58:43 +0100 kay at vrfy.org said:
>> On Fri, Nov 30, 2012 at 1:45 PM, Ramkumar Ramachandra
>> <artagnon at gmail.com> wrote:
>> > Kay Sievers wrote:
>> >> On Fri, Nov 30, 2012 at 1:28 PM, Zbigniew Jędrzejewski-Szmek
>> >> <zbyszek at in.waw.pl> wrote:
>> >>
>> >>> It'll be created by systemd during init if not present. So we _do_ a
>> >>> kind of around.
>> >
>> > Where is the creation code?  The systemd-machine-id-setup binary does
>> > _not_ create it, and my patch proposes to fix that.
>>
>> We overmount an empty file if needed. We do not want to create
>> anything if we do not know what to do, we should just fail with an
>> explaination, not mess around in the system!
>
> It would be nice to at least do an overmount in cases where something
> sane for a default could be created at boot.

We obviously cannot over mount a non-existing file :) You have to
leave it empty, then we will do that.

> For kicks I removed
> /etc/machine-id on a test machine and the machine no longer booted,

Well, a fork in the eye hurts or kicks sometimes. :)

> instead just spewing to the console repeatedly:
>         systemd[1]: Failed to start Journal Service.

Yeah, right, the error should tell what's wrong.

Kay