[systemd-devel] [PATCH] mount: make sure m->where is set before unit_add_exec_dependencies()

Lennart Poettering lennart at poettering.net
Mon Oct 22 16:57:59 PDT 2012


On Tue, 16.10.12 17:04, Will Woods (wwoods at redhat.com) wrote:

> If you enter unit_add_exec_dependencies with m->where = NULL, you'll
> very likely end up aborting somewhere under socket_needs_mount.
> 
> (When systemd goes to check to see if the journald socket requires your
> mount, it'll do path_startswith(path, m->where)... *kaboom*)
> 
> This patch should ensure that:
> 
>     a) both branches in mount_add_one() set m->where, and
>     b) mount_add_extras() calls unit_add_exec_dependencies() *after*
>        setting m->where.

Thanks! Applied! Sorry for the delay!

Lennart

-- 
Lennart Poettering - Red Hat, Inc.


More information about the systemd-devel mailing list