[systemd-devel] [PATCH] Fix a fatal dbus abort in bus_manager_message_handler()

[Eelco Dolstra]

Hi,

On 31/10/12 13:48, Colin Walters wrote:

>> @@ -495,7 +495,6 @@ static DBusMessage *message_from_file_changes(
>>          return reply;
>>  
>>  oom:
>> -        dbus_message_unref(reply);
>>          return NULL;
>>  }
> 
> This first change looks wrong to me - I don't see a cleanup attribute on
> the reply member in git master at least - v195-103-g173fa08 here.

Oops, you're right.  Searching for calls to dbus_message_unref I mistook the
"oom" label in message_from_file_changes() for the one in
bus_manager_message_handler().  So this one should stay.

-- 
Eelco Dolstra | LogicBlox, Inc. | http://nixos.org/~eelco/