[systemd-devel] [PATCH] [RFC] systemd-bootchart: merge bootchart.

[Kok, Auke-jan H]

On Wed, Oct 31, 2012 at 11:30 AM, Zbigniew Jędrzejewski-Szmek
<zbyszek at in.waw.pl> wrote:
> On Wed, Oct 17, 2012 at 04:01:12PM -0700, Auke Kok wrote:
>> << do not merge this patch - it has not been fully tested yet >>
> Hi,

thanks for taking the time to review!

>> This is an initial RFC patch merging bootchart almost verbatim
>> into systemd.
>>
>> Bootchart is renamed to 'systemd-bootchart' and installed as
>> $libdir/systemd/systemd-bootchart. The configuration file
>> will reside in $sysconfdir/systemd/bootchart.conf.
> Does this mean that there'll be a file in /etc/systemd/ always?
> This goes against the practice of moving default configuration
> to /usr.

no, the defaults are perfectly fine and ordinary users should have no
need to modify any of the settings. We can opt to not install the
config file by default as well.

> Would be nicer to leverage conf-files.[ch] and conf-parser.[ch].

agreed, this is one of the rewrite parts.

> Also, if the binary is supposed to be invoked directly,
> then is should go into /usr/bin, not /usr/libexec.

/usr/lib/systemd - not /usr/libexec. And systemd-readahead also has a
"analyze" option that is for interactive use, so that folder should
really be fine.

>> The code is almost unchanged. Graphing routines and logging code
>> do not use or leverage any additional systemd data that may be
>> available. This work is planned after the initial merge.
> Some notes inline below. Also some suggestions for rewordings
> in the documentation. Nothing important really.

I'll get to these in a separate thread. Thanks again for taking the
time to go through this in detail.

My expectation is not to sit on top of bootchart forever, but merge it
and clean it up over time. By itself there are so many things that
need adjustment that it would take me months to get through all the
comments and TODO items I've collected (including the ones I have not
written down).

The comments are very helpful, though. I'll either pick most of them
up right away or include them in the bootchart TODO.

Auke