[systemd-devel] (no subject)

[Colin Guthrie]

'Twas brillig, and Lennart Poettering at 12/09/12 07:34 did gyre and gimble:
> On Mon, 03.09.12 23:46, Colin Guthrie (colin at mageia.org) wrote:
> 
>> Hi,
> 
> Heya,
>>
>> OK, so these are the changes I'd propose to fix the issues mentioned
>> in this thread. I've not tested them so this is more for general
>> feedback as to whether this approach is generally a good one or not.
>>
>> The initial patch is just extra debugging I added to try and work out
>> why my gdm session is not marked with type=greeter so seems like a
>> generally useful change when in debug mode.
> 
> I merged all your patches. Thanks!

\o/

> I made one little change though: the require_active parameter now is a
> tree state:
> 
> < 0   -- return *all* sessions/seats of a user
> == 0  -- return online/active sessions/seats of a user
>> 0   -- return active sessions/seats of a user
> 
> I think this is the nicest way to model this. It does change a bit the
> meaning of the param from before but one could argue that this change
> actually unbreaks PA without making any changes necessary in PA, right? 
> 
> (I update the man page accordingly)

Yup, I prefer these semantics too TBH (I think that's what I said in my
mail after the patch was written. And yes, this should mean no changes
are needed in PA (or other similar programs which could be affected),
which I think is better even with the slight change in the meaning of
the param.

> Thanks for the thorough investigation of the problem and the flawless
> patches!

No worries :)

Col


-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited http://www.tribalogic.net/
Open Source:
  Mageia Contributor http://www.mageia.org/
  PulseAudio Hacker http://www.pulseaudio.org/
  Trac Hacker http://trac.edgewall.org/