[systemd-devel] [PATCH] tmpfiles: plug file descriptor leak.

Dave Reisner dreisner at archlinux.org
Wed Sep 12 13:21:00 PDT 2012


Introduced in d4e9eb91.
---
Sorry Lennart, I should have pointed this out along with my nudging last night
on IRC about the prior patch.

 src/tmpfiles/tmpfiles.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/tmpfiles/tmpfiles.c b/src/tmpfiles/tmpfiles.c
index 70de06b..ed51ec8 100644
--- a/src/tmpfiles/tmpfiles.c
+++ b/src/tmpfiles/tmpfiles.c
@@ -528,6 +528,8 @@ static int write_one_file(Item *i, const char *path) {
                 }
         }
 
+        close_nointr_nofail(fd);
+
         if (stat(path, &st) < 0) {
                 log_error("stat(%s) failed: %m", path);
                 return -errno;
-- 
1.7.12



More information about the systemd-devel mailing list