[systemd-devel] [PATCH] cryptsetup-generator: Add JobTimeoutSec=0 for all known crypt devices

[Lennart Poettering]

On Wed, 03.04.13 17:02, Harald Hoyer (harald at redhat.com) wrote:

> > Well, this explanation is too short. You need to clarify that this only
> > has an effect on devices listed in fstab with their device mapper path
> > (i.e. rather than LABEL= or UUID=, which is by far more common). For the
> > generic case there is no way around setting x-systemd.device-timeout=0
> > in fstab, because we wouldn't know that the fs with that label or uuid
> > is hidden behind a certain encrypted device before we have decrypted
> > it.
> 
> This is not true. This also affects LVM on top of the cryptsetup devices, where
> none of the /dev/mapper devices is and can be in /etc/fstab.

Well, LVM does not care about proper dependencies. They still are so
naive to assume they are run at a point in time where all devices are
probed.

Whether or not .device units exist is pretty much ignored by LVM.

> > This really needs to be clarified in both the commit msg and in the
> > comments of the code.
> > 
> >> +                p = strjoin(arg_dest, "/dev-mapper-", e, ".device.d/50-JobTimeoutSec0.conf", NULL);
> > 
> > We currently don't really use CamelCase file names, would prefer to call
> > this 50-job-timeout-sec-0.conf or so.
> 
> ok
> 
> > 
> > Also, please use write_string_file(), this should shorten the code quite
> > a bit.
> 
> err.. I just used the same style like in the rest of the file.

Well, not an excuse to make the same mistake... ;-)

Lennart

-- 
Lennart Poettering - Red Hat, Inc.