[systemd-devel] [PATCH] Always use our own MAX/MIN definitions

[Lennart Poettering]

On Mon, 01.04.13 03:08, Cristian Rodríguez (crrodriguez at opensuse.org) wrote:

> code in src/shared/macro.h only defined MAX/MIN in case
> they were not defined previously. however the MAX/MIN
> macros implemented in glibc are not of the "safe" kind but defined
> as:
> 
> define MIN(a,b) (((a)<(b))?(a):(b))
> define MAX(a,b) (((a)>(b))?(a):(b))
> 
> Avoid nasty side effects by using our own versions instead.

Just wondering: nasty side effects? Can you elaborate? In real-life it
shouldn't matter too much, should it?

Lennart

-- 
Lennart Poettering - Red Hat, Inc.