[systemd-devel] PATCH - add ARM based Chromebook lid switch

[Koen Kooi]

Op 12 apr. 2013, om 18:24 heeft Robert Schweikert <rjschwei at suse.com> het volgende geschreven:

> Thanks Kay for pointing me in the right direction
> 
> 
> From fced3673ee1001dc905206f9a92ea2062f951d3c Mon Sep 17 00:00:00 2001
> From: Robert Schweikert <rjschwei at suse.com>
> Date: Fri, 12 Apr 2013 12:08:16 -0400
> Subject: [PATCH] rules: add lid switch of ARM based Chromebook as a power
> switch to logind
> 
> ---
> src/login/70-power-switch.rules | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/src/login/70-power-switch.rules b/src/login/70-power-switch.rules
> index 36fb827..d925ab7 100644
> --- a/src/login/70-power-switch.rules
> +++ b/src/login/70-power-switch.rules
> @@ -9,5 +9,6 @@ ACTION=="remove", GOTO="power_switch_end"
> 
> SUBSYSTEM=="input", KERNEL=="event*", SUBSYSTEMS=="acpi", TAG+="power-switch"
> SUBSYSTEM=="input", KERNEL=="event*", KERNELS=="thinkpad_acpi", TAG+="power-switch"
> +SUBSYSTEM=="input", KERNEL=="event*", KERNELS=="gpio-keys.8", TAG+="power-switch"

Won't that trigger on every gpio-keys entry that devicetree labels as 8? I don't think it's a lid switch for all boards with gpio-keys.8 out there and even if it was, the .8 is just as stable as ethX, you shouldn't depend on it.

regards,

Koen