[systemd-devel] Journal issues

[Steven Hiscocks]

On 13/04/13 00:00, Mirco Tischler wrote:
> 2013/4/12 Steven Hiscocks <steven-systemd at hiscocks.me.uk
> <mailto:steven-systemd at hiscocks.me.uk>>
>
>     Hi,
>
>     I'm having two issues in relation to the journal with my recent
>     upgrade to v201.
>
>     One issue, is that it appears that "_MACHINE_ID" field is missing
>     the "=" character. I had a quick look, and I think the bug was
>     introduced on the last part of the following commit:
>     http://cgit.freedesktop.org/__systemd/systemd/commit/src/__journal/journald-server.c?id=__adb435bb70815461eeddf44dd5d6f1__fc2ad9026d
>     <http://cgit.freedesktop.org/systemd/systemd/commit/src/journal/journald-server.c?id=adb435bb70815461eeddf44dd5d6f1fc2ad9026d>
>
>     The second issue, is it appears that "_SOURCE_MONOTONIC_TIMESTAMP"
>     is being truncated to just "_SOURC". I'm not clear where this issue
>     was introduced.
>
> Hi
> My guess is
> http://cgit.freedesktop.org/systemd/systemd/commit/src/journal/journald-server.c?id=a569398925430de1f8479262e8ab39502054f2e9
>
Ah. I did look at this and it seemed okay...but now I've seen your patch 
it's jumped out at me ;)
>     Both issues can be easily seen with journalctl output in "export"
>     format. I've seen this issue on two of Arch Linux x86_64 systems.
>
>     Thanks :)
>
> A patch to fix this follows up.
>
Thanks Mirco :)
> On an unrelated note: Is DECIMAL_STR_MAX() in macro.h broken for types
> longer than 64 bit, or am I just too thick to understand this line:
> sizeof(type) <= 8 ? 20 : sizeof(int[-2*(sizeof(type) > 8)])))
> ?
>
> Thanks
> Mirco

-- 
Steven Hiscocks