[systemd-devel] [PATCH] Add support for initial state of NumLock

[Lennart Poettering]

On Fri, 12.04.13 18:53, Stanislav Brabec (sbrabec at suse.cz) wrote:

> Add support for setting of initial state of NumLock. Supported values
> are "yes", "no" and "bios" (on x86 platforms).
> 
> It sets NumLock in virtual consoles. If NumLock should be turned on, it
> also creates empty /run/numlock-on, which can be used e. g. for setting
> of X session default.
> 
> This ports a feature that exists for a long time in SUSE to systemd.

Humm, so this without doubt sounds like a useful feature, but I am
pretty sure systemd is the wrong place to do this.

To inherit the num lock state from the BIOS to kernel please fix this
problem at the source, and fix the kernel to simply inherit the state. I
am not sure we should add BIOS parsing code to systemd, this really
sounds like a job for the kernel.

And to inherit the num lock state from the kernel to X11, then please
fix this problem at the source, too, and fix X11 to to simply inherit
the state. I am pretty sure we shouldn't shadow flags which are
maintained anyway in another file, if X11 could get the same data
directly from the kernel.

What I am open to do is adding a setting to override whatever is set in
the BIOS from vconsole based on a configuration file. But the inheriting
stuff between BIOS/vconsole/X11 that's what I am not OK with.

Lennart

-- 
Lennart Poettering - Red Hat, Inc.