[systemd-devel] [PATCH] Fix spelling errors using 'codespell' tool

Zbigniew Jędrzejewski-Szmek zbyszek at in.waw.pl
Mon Apr 15 05:41:57 PDT 2013


On Sun, Apr 14, 2013 at 09:29:25PM -0700, David Strauss wrote:
> On Sun, Apr 14, 2013 at 7:42 PM, Anatol Pomozov
> <anatol.pomozov at gmail.com> wrote:
> > I am not sure about this change though. "sevice" looks like a spelling
> > as later in code this field is called "service". dbus gurus could you
> > please check what name should be used here?
> 
> I'm not a DBus expert, but the "sevice" argument is used positionally
> (as in the name doesn't matter) in pam-module.c on line 495. It's used
> again positionally in logind-dbus.c on line 349. The string "sevice"
> doesn't appear anywhere else in the code. So, unless something
> external is relying on the misspelling, it should be safe to rename.
Yeah, this change is unlikely to cause problems.

Applied.

Zbyszek


More information about the systemd-devel mailing list