[systemd-devel] [PATCH] systemd-python: export new sd_journal_{process, get_events, get_timeout}

[Zbigniew Jędrzejewski-Szmek]

On Mon, Apr 15, 2013 at 08:24:08AM +0100, Steven Hiscocks wrote:
> On 14/04/13 23:55, Zbigniew Jędrzejewski-Szmek wrote:
> >get_timeout_ms is added as a convenience function, since
> >it is abysmally hard to call clock_gettime() in Python
> >versions lower than 3.3. And even for Python 3.3 users
> >it saves a few lines.
> >---
> >Hello,
> >
> >I'd apply this directly, but since we're currently discussing changes
> >pin the API, I thought it'd be better if you had a look. Comments,
> >suggestions?
> >
> >Zbyszek
> 
> Only thought is whether you think it would be good to add "poll" to
> the method names for the `get...` ones. e.g. get_poll_events,
> get_poll_timeout, etc.
> 
> Otherwise looks good to me :)
Might not have been a bad idea, but we already have get_reliable_fd,
get_timeout. I think that for consistency reasons it is better not to
add it.

Zbyszek