[systemd-devel] [PATCH] python-systemd: Reader return special fields and _Reader changes

[Zbigniew Jędrzejewski-Szmek]

On Sun, Apr 14, 2013 at 08:55:08PM +0100, Steven Hiscocks wrote:
> From: Steven Hiscocks <steven at hiscocks.me.uk>
> 
> Changes to _Reader make it match closer to C API, by removing `get_next`
> and `get_previous`. A `get_all` method added, which returns dictionary
> of fields using C API SD_JOURNAL_FOREACH_DATA macro, which can be used
> in conjunction with `next`.
> 
> _Reader `get`, `next`, `get_{realtime,monotonic,cursor}` and new
> `previous` methods are made private. This is so the traversal and
> getting of journal fields can be made transparent in the python
> interface.
> 
> Reader now solely implements `get_next` and `get_previous`, returning a
> standard dictionary (future: other mapping types?) with all standard and
> special fields through the converters. This makes the output the same as
> journalctl json/export format output.
> 
> Iterator methods also moved to Reader, as they do not function as intend
> with changes to _Reader.
> 
> These changes also mean that more optimised journal interfaces can be
> made more easily from _Reader, by avoiding getting of unrequired fields
> by using the `_get` method, and avoiding field conversions.
Applied. Thanks!

Zbyszek