[systemd-devel] [PATCH] bus: Use memalign() if aligned_alloc() isn't available

Lennart Poettering lennart at poettering.net
Wed Apr 17 09:38:38 PDT 2013


On Wed, 17.04.13 18:12, Kay Sievers (kay at vrfy.org) wrote:

> 
> On Wed, Apr 17, 2013 at 6:09 PM, Henrik Grindal Bakken <hgb at ifi.uio.no> wrote:
> > Kay Sievers <kay at vrfy.org> writes:
> >
> >> On Wed, Apr 17, 2013 at 5:49 PM, Henrik Grindal Bakken <hgb at ifi.uio.no> wrote:
> >>> Use <features.h> and _GNU_SOURCE to determine if _ISOC11_SOURCE is
> >>> available, and with that, aligned_alloc().
> >>
> >> Can't you just define the missing function in missing.h to the one we
> >> use, instead of directly blowing up the code with compat stuff and
> >> ifdefs?
> >
> > Sure I can.  Didn't know about missing.h.  Will fix.
> 
> Yeah, the idea of missing.h is to make stuff look like it is there. We
> usually just decide on one option, and cover older stuff from there.
> :)

Well, our current usage of aligned_alloc() is not even calling it
correctly... We really should sotp using that. Let's use memalign()
everywhere.

Lennart

-- 
Lennart Poettering - Red Hat, Inc.


More information about the systemd-devel mailing list