[systemd-devel] [PATCH] buildsys: Add --disable-tests to avoid building tests

[Henrik Grindal Bakken]

Kay Sievers <kay at vrfy.org> writes:

> On Wed, Apr 17, 2013 at 5:49 PM, Henrik Grindal Bakken <hgb at ifi.uio.no> wrote:
>> This patch adds --disable-tests to configure.  It is based on a patch
>> posted by Thierry Reding in 2010.  The motivation for adding it is
>> that some tests fail link-time when cross-compiling.
>
> Can't the tests get its own variables, and we assign these variablse
> conditionally to the original variables to take effect, instead of
> nesting even more ifdefs?

I notice that some tests are added to noinst_PROGRAMS, while others are
added to noinst_tests.  I'm not sure what the difference between the two
are.  An alternative (and simpler) patch would be to add all tests to
noinst_tests (unconditionally), and then add noinst_tests to
noinst_PROGRAMS only if ENABLE_TESTS is true.

I can send an alternative patch.


-- 
Henrik Grindal Bakken <hgb at ifi.uio.no>
PGP ID: 8D436E52
Fingerprint: 131D 9590 F0CF 47EF 7963  02AF 9236 D25A 8D43 6E52