[systemd-devel] [PATCH v3] buildsys: Add --disable-tests to avoid building tests

[Henrik Grindal Bakken]

Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl> writes:

> On Wed, Apr 17, 2013 at 07:36:47PM +0200, Henrik Grindal Bakken wrote:
>> This patch adds --disable-tests to configure.  It is based on a patch
>> posted by Thierry Reding in 2010.  The motivation for adding it is that
>> some tests fail link-time when cross-compiling.
>> 
>> The patch adds a new Makefile variable -- noinst_test_programs -- and uses
>> that instead of noinst_PROGRAMS.  However, if ENABLE_TESTS is true,
>> the former is added to the latter.

>> +noinst_PROGRAMS = $(noinst_test_programs) $(noinst_tests)
>>  TESTS = $(noinst_tests)
>> +else
>> +noinst_PROGRAMS =
>> +TESTS =
>> +endif
>>  udevlibexec_PROGRAMS =
> Hm, maybe rename noinst_test_programs to 'manual_tests', and
> noinst_tests to just 'tests'. noinst_ is just for automake.  This way
> it'll be clearer that 'manual_tests' are tests that are not run
> automatically.

Good point.  I'll do that.

>> +AC_ARG_ENABLE(tests,
>> +       [AC_HELP_STRING([--disable-tests], [build tests])],
>> +       enable_tests=$enableval, enable_tests=yes)
>> +AM_CONDITIONAL(ENABLE_TESTS, [test x$enable_tests = xyes])
>> +
> Are you sure that this is enabled by default? The docstring seems
> to be opposite of the actual meaning.

Yeah, it's enabled (or, at least, it builds the tests for me without
--disable-tests), but as you point out, the help text is all wrong.


-- 
Henrik Grindal Bakken <hgb at ifi.uio.no>
PGP ID: 8D436E52
Fingerprint: 131D 9590 F0CF 47EF 7963  02AF 9236 D25A 8D43 6E52