[systemd-devel] [PATCH] udev: fail firmware loading immediately if no search path is defined

[Tom Gundersen]

Hi Maarten,

On 7 Aug 2013 09:52, "Maarten Lankhorst" <m.b.lankhorst at gmail.com> wrote:
> So what is wrong with my 'fail in udev immediately if not configured'
idea? In that case it
> doesn't matter whether CONFIG_FW_LOADER_USER_HELPER is set or not.

Well that would break the case for anyone who actually wants to use a
non-udev user space helper (which is the only situation where this
configuration actually makes sense). I don't necessarily think that using
such a helper is a sensible thing to do, but if we don't want to support
that we should just drop the option from the kernel rather than make udev
override the kernel configuration.

> You could even print a useful message for the user in udev to the log, so
they have an idea of what
> happened. Breaking udev on older still supported kernels by default
without printing any debug info
> is silly, and the only cost is a small increase in disk space when
unused. I did so in below patch.

It would be simple enough to add an udev rule to just print 'ignoring
firmware event' to the logs. We should really ignore the event though, and
not cancel it. Not sure if this is something we want upstream (after all,
there are plenty of situations where we don't warn if the recommendations
in the README file are not followed), or if distros and whoever wants it
should ship that themselves. I'll leave that for Kay to decide.

Lastly, note that the plan is to drop all the firmware code from udev in
the not too distant future, so it doesn't really maker much sense to add
new functionality to that at this point.

Cheers,

Tom
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20130810/4104b605/attachment.html>