[systemd-devel] [PATCH] Recognize discard option in /etc/crypttab

[Zbigniew Jędrzejewski-Szmek]

On Fri, Aug 09, 2013 at 08:37:52PM +0200, Michael Stapelberg wrote:
> Hi,
> 
> forwarding this patch we received in the Debian bugtracker.
> 
> systemd-cryptsetup recognizes option 'allow-discards' in /etc/crypttab
> to enable TRIM passthrough to underlying encrypted device. In Debian
> this option was changed to 'discard' to avoid hyphen in option name
> (see: #648868 and `man crypttab`).
> 
> The attached patch makes “discard” a synonym for “allow-discards” in
> /etc/crypttab. Please merge it.
Hi,
I applied the patch, also making a change in the documentation
to prefer "discard" to "allow-discards" (both remain supported of course).
I don't think we should care about some script linking dashes or not,
but consistency is important, and since various filesystems already
use discard, there's no point to differ here. Also "discard" is easier
to remember and type than "allow-discards".

Zbyszek