[systemd-devel] [PATCH 1/5] configure.ac: Add option to disable configuring the BIOS test

[Darren Hart]

On Wed, 2013-08-21 at 21:15 +0200, Kay Sievers wrote:
> On Wed, Aug 21, 2013 at 8:13 PM, Darren Hart <dvhart at linux.intel.com> wrote:
> > When cross-compiling, AC_CHECK_FILE aborts configure. Provide a means to
> > avoid even attempting to configure the BIOS test.
> >
> > Signed-off-by: Darren Hart <dvhart at linux.intel.com>
> > ---
> >  configure.ac | 10 +++++++---
> >  1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git a/configure.ac b/configure.ac
> > index ca5a383..6ee4520 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -66,9 +66,13 @@ AC_SUBST([ARCH])
> >  AC_SUBST([MACHINE_TYPE_NAME])
> >
> >  # test bios
> > -AC_CHECK_FILE([/usr/lib/qemu-bios],        [BIOS=/usr/lib/qemu-bios])
> > -AC_CHECK_FILE([/usr/share/qemu-ovmf/bios], [BIOS=/usr/share/qemu-ovmf/bios])
> > -AC_SUBST([BIOS])
> > +AC_ARG_ENABLE(biostest, AS_HELP_STRING([--disable-biostest], [disable building BIOS test]))
> > +if test "x$enable_biostest" != "xno"; then
> > +       AC_CHECK_FILE([/usr/lib/qemu-bios],        [BIOS=/usr/lib/qemu-bios])
> > +       AC_CHECK_FILE([/usr/share/qemu-ovmf/bios], [BIOS=/usr/share/qemu-ovmf/bios])
> > +       AC_SUBST([BIOS])
> > +fi
> > +AM_CONDITIONAL(ENABLE_BIOSTEST, [test "x$enable_biostest" = "xyes"])
> 
> This is commonly done with $cross_compiling. Any specific reason to
> have a new switch?
>   http://www.gnu.org/software/autoconf/manual/autoconf.html#index-cross_005fcompiling-1186
> 

No good reason, I'd be fine using the cross_compiling switch as well.

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel