[systemd-devel] [PATCH 5/5] Auto detect both x64 and ia32 boot*.efi payloads

[Kay Sievers]

On Thu, Aug 22, 2013 at 1:12 AM, Zbigniew Jędrzejewski-Szmek
<zbyszek at in.waw.pl> wrote:
> On Thu, Aug 22, 2013 at 12:49:55AM +0200, Kay Sievers wrote:
>> On Thu, Aug 22, 2013 at 12:38 AM, Zbigniew Jędrzejewski-Szmek
>> <zbyszek at in.waw.pl> wrote:
>> > On Wed, Aug 21, 2013 at 03:07:24PM -0700, Darren Hart wrote:
>> >> On Wed, 2013-08-21 at 23:37 +0200, Kay Sievers wrote:
>> >> > On Wed, Aug 21, 2013 at 11:34 PM, Darren Hart <dvhart at linux.intel.com> wrote:
>> >> >
>> >> > > Hrm, actually no.... that fails finding VERSION ins setup.c. Did
>> >> > > you ./autogen.sh before building?
>> >> >
>> >> > Oh, sorry, it probably just misses:
>> >> >
>> >> > +gummiboot_CPPFLAGS = \
>> >> > +       $(AM_CPPFLAGS) \
>> >> >
>> >> > Kay
>> >>
>> >> OK, so you'd prefer to move the -D* args to the CPPFLAGS? I can respin
>> >> with that with only minimal build testing as that was failing on the
>> >> host as well.
>> > Or better append the define on line 173 in Makefile.am, with all other
>> > defines. We only define per-target cflags when the name is not generic
>> > enough.
>>
>> 173? This is gummiboot.git, you are looking at systemd?
> Wait, gummiboot hasn't been incorporated into systemd yet?

No, not so far. :)

>  OK, then
> please disregard my comments. Yeah, I was thinking about systemd,
> and didn't know that gummiboot doesn't use autotools.

gummiboot uses autotools, but the EFI build is somewhat special and we
bypass most of the autofoo stuff:
  http://cgit.freedesktop.org/gummiboot/tree/Makefile.am#n71

There is a /usr/bin/gummiboot tool though, in the same source tree,
and it uses the normal autofoo stuff.

Kay