[systemd-devel] [RFC] mount: improve DefaultDependencies and use in generator

Tom Gundersen teg at jklm.no
Wed Aug 21 19:19:37 PDT 2013


On Wed, Aug 21, 2013 at 10:06 PM, Thomas Bächler <thomas at archlinux.org> wrote:
> Am 21.08.2013 13:53, schrieb Tom Gundersen:
>> I'd like to move some of the default dependency logic from the fstab generator
>> to core. This should remove some redundancy and also improve consistency
>> between mount units and fstab entries.
>>
>> The first patch simply enables default dependencies in the generator, and
>> removes some things that are then made redundant.
>>
>> The second patch moves the handling of device dependencies from the generator
>> to core's default dependencies.
>
> DefaultDependencies=yes implicitly adds Before=foo.target for every
> target "foo" that wants or requires the unit.
>
> This has a negative effect on auto,x-systemd.automount mounts: Enabling
> DefaultDependencies will make the generated .mount unit
> Before=local-fs.target, which will remove the speed-up gained by
> delaying the mount.

Good catch.

Any objections to making the mount targets "DefaultDependencies=no"
(and add a conflict with shutdown.target)?

Just reading the manpages (and not checking all the code paths), this
should not have any adverse effects.

Comments?

Tom


More information about the systemd-devel mailing list