[systemd-devel] [PATCH] Split sysctl 50-default.conf setting file

[Goffredo Baroncelli]

On 2013-12-02 21:32, Kay Sievers wrote:
> On Mon, Dec 2, 2013 at 9:15 PM, Goffredo Baroncelli <kreijack at libero.it> wrote:
>> currently systemd contains a sysctl default setting in a file called
>>         50-default.conf
>> The aim of this patch is to split the content of the sysctl setting in
>> more files to allow a more selective override.
>>
>> My need is to enable all the sysrq key. Instead systemd defaults is to
>> disallow all sysrq keys except the sync one [1].
>> To do that, I would have to override the sysctl file
>>         /usr/lib/sysctl.d/50-default.conf file,
>> putting a file with the same name in
>>         /etc/sysctl.d
>> However this file contains other settings than the one which I want to
>> override; so I would lost any update of these other settings made by
>> upstream.
>>
>> With this patch I am able to override only the setting related to the sysrq.
> 
> You should be able to overwrite individual settings just fine. I don't
> think this is needed.

What happens if the same sysctl is present is in two files: the value is
written two times, or systemd-sysctl is smart enough to write only the
last one ?

I have to point out that I spent some time to find who changed this
setting when I installed systemd. A more explicit name file would helped.

> 
>> create mode 100644 sysctl.d/50-default_kernel_sysrq.conf
> 
> We usually don't do "_" in file names. :)

Just for curiosity: there is a rationale or it is a convention (I am
fine with removing "_", but I am curious about the reason)
> 
> Kay
> _______________________________________________
> systemd-devel mailing list
> systemd-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel
> 


-- 
gpg @keyserver.linux.it: Goffredo Baroncelli (kreijackATinwind.it>
Key fingerprint BBF5 1610 0B64 DAC6 5F7D  17B2 0EDA 9B37 8B82 E0B5