[systemd-devel] [PATCH] busname: check the service state instead of the busname state

Thomas H.P. Andersen phomes at gmail.com
Wed Dec 4 13:37:33 PST 2013


git send-email is sadly still not working for me. I am pasting the
patch here and attaching it as well.

In busname_trigger_notify the last check uses IS_SET on the
busname's state but compares it to service states.

I assume that the intended logic was to check the service's
state instead.
---
 src/core/busname.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/core/busname.c b/src/core/busname.c
index c452656..0151ee0 100644
--- a/src/core/busname.c
+++ b/src/core/busname.c
@@ -526,7 +526,7 @@ static void busname_trigger_notify(Unit *u, Unit *other) {
                         busname_enter_listening(n);
         }

-        if (IN_SET(n->state,
+        if (IN_SET(s->state,
                    SERVICE_DEAD,
                    SERVICE_STOP, SERVICE_STOP_SIGTERM, SERVICE_STOP_SIGKILL,
                    SERVICE_STOP_POST, SERVICE_FINAL_SIGTERM,
SERVICE_FINAL_SIGKILL,
-- 
1.8.4.2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-busname-check-the-service-state-instead-of-the-busna.patch
Type: text/x-patch
Size: 1056 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20131204/8ae2feb5/attachment.bin>


More information about the systemd-devel mailing list