[systemd-devel] systemd unit review requested

[Zbigniew Jędrzejewski-Szmek]

On Thu, Dec 05, 2013 at 04:50:54PM +1000, Peter Hutterer wrote:
> the new rule now is:
> 
> SUBSYSTEM=="tty|pnp", KERNEL=="ttyS[0-9]*", ATTRS{id}=="WACf*", \
>     ENV{SYSTEMD_WANTS}="wacom-inputattach@%k.service",TAG+="systemd"
> 
> 
> And the matching wacom-inputattach at .service file shows:
> 
> [Unit]
> Description="Start inputattach for Wacom ISDv4-compatible serial devices"
> 
> [Service]
> Type=simple
> ExecStartPre=/usr/sbin/modprobe wacom_w8001
> ExecStart=/usr/bin/inputattach -w8001 /dev/%I
> 
> Anything I'm missing, anything I should change?
Looks OK, except for the question where the module should be loaded from,
discussed in the other part of this thread.

> Also, do I need this in any target, or is dropping this into
> /usr/lib/systemd/system/ enough?
Yes, but wait until https://bugzilla.redhat.com/show_bug.cgi?id=1026860
is fixed (hopefully today).

Zbyszek