[systemd-devel] [PATCH] systemctl: fix and refactor wait_for_jobs
Zbigniew Jędrzejewski-Szmek
zbyszek at in.waw.pl
Sat Dec 7 08:37:11 PST 2013
On Sat, Dec 07, 2013 at 01:21:10PM +0100, Thomas H.P. Andersen wrote:
> I was a bit unsure what to do here. We can be waiting for multiple
> jobs that each can fail. We could return an error on the first failure
> but then we would not call log_error for the remaining issues. The
> question is then what to return in the case of multiple errors? With
> this patch (and the behavior before the sd-bus port) the last error
> encountered is returned as we just overwrite the value in r.
Maybe make it the first error? We usually try to return the first,
as it is most likely to be meaningful.
Zbyszek
More information about the systemd-devel
mailing list