[systemd-devel] [PATCH v3 00/26] Initial DHCP v4 library implementation
Zbigniew Jędrzejewski-Szmek
zbyszek at in.waw.pl
Mon Dec 9 19:03:48 PST 2013
On Mon, Dec 09, 2013 at 11:43:06PM +0200, Patrik Flykt wrote:
> Hi,
>
> Here is version 3 fixed according to comments plus a few identical ones
> found in the code.
>
> Essential changes are unconditionally compiling the DHCP code and re-adding
> the sd_dhcp_client_get_netmask() function due to popular demand. Prefix
> length computation is turned into a support function instead.
>
> The timer problem was solved, the timer callback function gets the supplied
> timeout value, in this case zero, and thus it miscalculated any further
> timer values causing them all to trigger "immediately".
>
> A proper directory should be selected for the code, currently it's still
> the same old src/dhcp.
If it is to be exported, it should be src/libsystemd-dhcp for
consistency with libsystemd-{bus,daemon,id128,rtnl}. I think we should
merge those patches now, and get networkd with dhcp working.
Zbyszek
More information about the systemd-devel
mailing list