[systemd-devel] [PATCH 6/8] add GOP mode setting and splash drawing support

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Tue Dec 10 00:56:54 PST 2013


On 10.12.2013 10:03, Greg KH wrote:
> On Tue, Dec 10, 2013 at 09:50:58AM +0200, Joonas Lahtinen wrote:
>> Add support for two new configuration directives gfxmode and splash
>> which respectively allow setting the screen graphics mode and drawing
>> splash image during gummiboot execution. See README.gop for more
>> details.
>>
>> Signed-off-by: Joonas Lahtinen<joonas.lahtinen at linux.intel.com>
>> Reviewed-by: Mikko Ylinen<mikko.ylinen at intel.com>
>> Acked-by: Darren Hart<dvhart at linux.intel.com>
>> ---
>>    Makefile.am         |   5 ++
>>    README.gop          |  46 ++++++++++++++++++
>>    configure.ac        |   7 +++
>>    src/efi/gop.c       | 137
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++
> Your patch is line-wrapped and can't be applied :(
>

So it seems. It actually looks just right on Thunderbird (99%), because 
it combines long lines somehow. But even on TB, it has failed to done so 
at some places (if the breaking has happened just before EOL, it skips 
both the breaking line feed and the real one), so the patches are broken 
anyway.

Thunderbird update has done something wonderful, it also lost all the 
threading information. Will send a new set of patches with mutt.

Regards, Joonas


More information about the systemd-devel mailing list