[systemd-devel] [PATCH v3 01/26] dhcp: Add DHCP protocol structures and initial defines

[Lennart Poettering]

On Tue, 10.12.13 14:15, Patrik Flykt (Patrik.Flykt at linux.intel.com) wrote:

> 
> On Tue, 2013-12-10 at 02:46 +0100, Lennart Poettering wrote:
> > > +        uint32_t ciaddr;
> > > +        uint32_t yiaddr;
> > > +        uint32_t siaddr;
> > > +        uint32_t giaddr;
> > 
> > Hmmm, why uin32_t? Shouldn't this be32_t? THis is network byte order,
> > right? which is just synoymous to big endian...
> > 
> > Or even, if you now use "struct in_addr" elsewhere anyway, why not
> > just use that here too?
> 
> be32_t seems reasonable, the 'struct in_addr' was deemed to add slightly
> too much cruft without being particularly useful in internal code. What
> if we figure out whether this patch set is otherwise reasonable and fix
> this and add the remaining parts of DHCP in a coming patch set?
> Meanwhile Tom could take the code for an official test spin...

This code looks as if it's ready to be merged. WHatever else comes up
can be fixed post-commit. I think it would be best if you'd get commit
access so that you can maintain this.

Could you request an fdo account if you don't have one please? If you
already do, please file a bug so that you get commit access to the
systemd repo.

http://www.freedesktop.org/wiki/AccountRequests/

Lennart

-- 
Lennart Poettering, Red Hat