[systemd-devel] [PATCH] test-fileio: replace mktemp with mkstemp to avoid warnings

Thomas H.P. Andersen phomes at gmail.com
Wed Dec 11 15:32:43 PST 2013


From: Thomas Hindoe Paaboel Andersen <phomes at gmail.com>

This is a fairly useless thing to do but it makes the compilers
and analyzers shut up about the use of mktemp.
---
 src/test/test-fileio.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/test/test-fileio.c b/src/test/test-fileio.c
index 06f3e28..b005f3b 100644
--- a/src/test/test-fileio.c
+++ b/src/test/test-fileio.c
@@ -41,7 +41,9 @@ static void test_parse_env_file(void) {
         char **i;
         unsigned k;
 
-        assert_se(mktemp(p));
+        fd = mkstemp(p);
+        assert_se(fd >= 0);
+        close(fd);
 
         fd = mkostemp(t, O_CLOEXEC);
         assert_se(fd >= 0);
@@ -152,7 +154,9 @@ static void test_parse_multiline_env_file(void) {
         _cleanup_strv_free_ char **a = NULL, **b = NULL;
         char **i;
 
-        assert_se(mktemp(p));
+        fd = mkstemp(p);
+        assert_se(fd >= 0);
+        close(fd);
 
         fd = mkostemp(t, O_CLOEXEC);
         assert_se(fd >= 0);
-- 
1.8.4.2



More information about the systemd-devel mailing list