[systemd-devel] [PATCH 11/11] util: remove union dirent_storage

Florian Weimer fweimer at redhat.com
Thu Dec 19 03:44:10 PST 2013


---
 TODO              | 1 -
 src/shared/util.h | 6 ------
 2 files changed, 7 deletions(-)

diff --git a/TODO b/TODO
index 2e3becc..1e8f2b0 100644
--- a/TODO
+++ b/TODO
@@ -48,7 +48,6 @@ Features:
   - ensure scope units may be started only a single time
 
 * code cleanup
-  - get rid of readdir_r/dirent_storage stuff, it's unnecessary on Linux
   - we probably should replace the left-over uses of strv_append() and replace them by strv_push() or strv_extend()
 
 * switch to SipHash for hashmaps/sets?
diff --git a/src/shared/util.h b/src/shared/util.h
index 3e0a6d5..488ce3b 100644
--- a/src/shared/util.h
+++ b/src/shared/util.h
@@ -44,12 +44,6 @@
 #include "macro.h"
 #include "time-util.h"
 
-union dirent_storage {
-        struct dirent de;
-        uint8_t storage[offsetof(struct dirent, d_name) +
-                        ((NAME_MAX + 1 + sizeof(long)) & ~(sizeof(long) - 1))];
-};
-
 /* What is interpreted as whitespace? */
 #define WHITESPACE " \t\n\r"
 #define NEWLINE "\n\r"
-- 
1.8.3.1



More information about the systemd-devel mailing list