[systemd-devel] [systemd-commits] 2 commits - TODO src/core

[Lennart Poettering]

On Sun, 22.12.13 15:30, Zbigniew Jędrzejewski-Szmek (zbyszek at in.waw.pl) wrote:

> 
> On Fri, Dec 20, 2013 at 03:54:32PM -0800, Lennart Poettering wrote:
> > New commits:
> > commit d86f9d5285742e959a158e743799506b5339fefc
> > Author: Lennart Poettering <lennart at poettering.net>
> > Date:   Sat Dec 21 00:19:37 2013 +0100
> > 
> >     core: pass notify fd across reexecs
> >     
> >     That way we the random socket name stays stable across reexec and we
> >     won't lose client messages.
> > 
> Hi Lennart,
> 
> >From #systemd:
> 04:14 < zbyszek> poettering: I just daemon-reexec'ed into HEAD~10 and I see a segfault:
> 04:14 < zbyszek> systemd[1]: Assertion 'm->notify_fd == fd' failed at src/core/manager.c:1283, function 
>                  manager_dispatch_notify_fd(). Aborting.
> 04:18 < zbyszek> http://paste.fedoraproject.org/63664/13875959
> 
> I didn't see anything in subsequent commits that would fix this.

Hmm, weird. I don't see how that could ever happen from the code... Do
you know a reproducer for this? reexec appears to work fine here...

Lennart

-- 
Lennart Poettering, Red Hat