[systemd-devel] [PATCH 1/4] bus: driverd; add missing format string parameter

[Lennart Poettering]

On Sat, 28.12.13 13:54, Marc-Antoine Perennou (Marc-Antoine at Perennou.com) wrote:

> This was causing a nasty coredump

Thanks! Applied!

(So this wasn't detected earlier due to a format string attribute fuckup
for sd_bus_error_setf() and a couple of other calls. Fixed those too.)

> ---
>  src/bus-driverd/bus-driverd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/bus-driverd/bus-driverd.c b/src/bus-driverd/bus-driverd.c
> index 57023ec..44172c4 100644
> --- a/src/bus-driverd/bus-driverd.c
> +++ b/src/bus-driverd/bus-driverd.c
> @@ -346,7 +346,7 @@ static int driver_remove_match(sd_bus *bus, sd_bus_message *message, void *userd
>  
>          m = hashmap_get(c->matches, normalized);
>          if (!m) {
> -                r = sd_bus_error_setf(error, SD_BUS_ERROR_MATCH_RULE_NOT_FOUND, "Match rule \"%s\" not found.");
> +                r = sd_bus_error_setf(error, SD_BUS_ERROR_MATCH_RULE_NOT_FOUND, "Match rule \"%s\" not found.", normalized);
>                  goto finish;
>          }
>  


Lennart

-- 
Lennart Poettering, Red Hat