[systemd-devel] [PATCH][V3] systemd-analyze: rewrite in C.

Kok, Auke-jan H auke-jan.h.kok at intel.com
Mon Feb 4 13:46:54 PST 2013

On Mon, Feb 4, 2013 at 1:33 PM, Peeters Simon <peeters.simon at gmail.com> wrote:
> 2013/2/4 Lennart Poettering <lennart at poettering.net>:
>> On Mon, 04.02.13 21:32, Simon Peeters (peeters.simon at gmail.com) wrote:
>>> Written by Peeters Simon <peeters.simon at gmail.com>. Makefile stuff
>>> and cleaned up a bit by Auke Kok <auke-jan.h.kok at intel.com>.
>>> ---
>> Hmm, how does this relate to this work:
>> https://bugzilla.freedesktop.org/show_bug.cgi?id=60112
> hmm, did not yet see this.
>> Can we merge both approaches?
> I will look at it further but my current toughts:
>  - the bus_parse_unit_info functions seems a good idea.
>  - his bus_get_uint64_property is slightly nicer than mine.
>  - it still uses cairo to write the plot which i think is not so nice.
>     (since it is overkill for writing svg)
>  - it seems like a more literal translation in some places.
>  - repeats some bugs that were in the original python version but
> fixed in my version.
>  - it does not print bars for firmware and loader into the svg output.
>  - it prints more informational text on the svg.
>  - quiet unfortunate that these patches did not end up on the mailing list.
>     (and apparently the poster did not see my patches on the list either)
> so I propose I try to merge the best of both patch-sets.
> any other comments with regards to this?

Simon, please comment on the bugzilla as well.

In general, I'm a bit hesitant to leave the cairo dependency in place
simply because it's not needed to do basic plotting.

The codeflow seems highly comparable - I think there's a lot of
overlap otherwise.

Let's make sure we incorporate the elements we can use from
Marc-Antoine - Marc-Antoine - it would be really helpful if you could
chime in on the list and support a joint effort.


More information about the systemd-devel mailing list