[systemd-devel] systemd-fsck change fsck arguments to "-a" -> "-y"

[Lennart Poettering]

On Thu, 07.02.13 16:57, Bryan Duff (bduff at ecessa.com) wrote:

> Would it be possible to add this as some kind of option to systemd-fsck?
> 
> In my case there was a situation where ext3 would not mount because
> of a timestamp issue that would not be fixed with "-a".

Every sane distro patches the timestamp check nonsense out of
e2fsck. Assuming the RTC was always correct is just so misguided, it
hurts... 

> 
> Thanks.
> 
> -Bryan

> diff --git a/src/fsck/fsck.c b/src/fsck/fsck.c
> index 058f34d..b1938c7 100644
> --- a/src/fsck/fsck.c
> +++ b/src/fsck/fsck.c
> @@ -321,9 +321,10 @@ int main(int argc, char *argv[]) {
>                  }
>  
>          cmdline[i++] = "/sbin/fsck";
> -        cmdline[i++] = "-a";
> +//        cmdline[i++] = "-a";
>          cmdline[i++] = "-T";
>          cmdline[i++] = "-l";
> +        cmdline[i++] = "-y";
>  

Hmm, I wonder if -a or -y is the way to go. Karel, as util-linux/fsck
maintainer, do you have an opinion whether we should use -a or -y for
automatic, non-interactive fscking? Is -a obsolete and -y the future?

Lennart

-- 
Lennart Poettering - Red Hat, Inc.