[systemd-devel] [PATCH] [RFC] Remove installation of symlinks in /etc

[Umut Tezduyar]

Hi,

If I am not mistaken, moving "getty at tty1.service" and "remote-fs.target" to
$systemunitdir will cause them to be shown as "disabled" on "systemctl
status .unit" even though they are enabled. These unit files have
"[Install]" sections and when there is "[Install]" section on them, systemd
will look for a symbolic link in /etc to determine if the unit is
enabled/disabled.

If the mentioned unit files are moving to $systemunitdir, then their
[Install] section needs to be removed as well so systemd can treat them as
"static" unit files.

Thanks


On Tue, Feb 12, 2013 at 1:34 AM, Auke Kok <auke-jan.h.kok at intel.com> wrote:

> Contrary to it's own packaging guidelines, these symlinks are created
> in /etc/. While technically not a problem, this makes it harder
> for folks installing from git that want to override these settings
> (either masking or otherwise).
>
> Moving the links to $(systemunitdir) resolves.
> ---
>  Makefile.am | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 2cec04a..8945cfa 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -3622,8 +3622,8 @@ USER_UNIT_ALIASES += \
>         $(systemunitdir)/sound.target sound.target
>
>  GENERAL_ALIASES += \
> -       $(systemunitdir)/remote-fs.target
> $(pkgsysconfdir)/system/multi-user.target.wants/remote-fs.target \
> -       $(systemunitdir)/getty at .service
> $(pkgsysconfdir)/system/getty.target.wants/getty at tty1.service \
> +       $(systemunitdir)/remote-fs.target
> $(systemunitdir)/multi-user.target.wants/remote-fs.target \
> +       $(systemunitdir)/getty at .service
> $(systemunitdir)/getty.target.wants/getty at tty1.service \
>         $(pkgsysconfdir)/user $(sysconfdir)/xdg/systemd/user \
>         ../system-services/org.freedesktop.systemd1.service
> $(dbussessionservicedir)/org.freedesktop.systemd1.service
>
> @@ -3650,8 +3650,8 @@ INSTALL_DIRS += \
>         \
>         $(userunitdir) \
>         $(pkgsysconfdir)/system \
> -       $(pkgsysconfdir)/system/multi-user.target.wants \
> -       $(pkgsysconfdir)/system/getty.target.wants \
> +       $(systemunitdir)/multi-user.target.wants \
> +       $(systemunitdir)/getty.target.wants \
>         $(pkgsysconfdir)/user \
>         $(dbussessionservicedir) \
>         $(sysconfdir)/xdg/systemd
> --
> 1.8.1
>
> _______________________________________________
> systemd-devel mailing list
> systemd-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20130212/f0c84d25/attachment.html>