[systemd-devel] [PATCH] bootchart: use conf-parser & CamelCase names in .conf

Lennart Poettering lennart at poettering.net
Wed Feb 13 11:31:07 PST 2013

On Wed, 13.02.13 20:24, Thomas Hindoe Paaboel Andersen (phomes at gmail.com) wrote:

Heya, looks good in principle.

> +        fn = "/etc/systemd/bootchart.conf";
> +        f = fopen(fn, "re");

No need to open this if you don't have a reason to. config_parse()
actually takes a NULL argument for the FILE* param, in which case it
will open the file on its own. Passing FILE* sometimes makes sense for
optimization when we do search path magic...

> +[Bootchart]
> +#Samples=500
> +#Freq=25
> +#Rel=0
> +#Filter=1
> +#Output=<folder name, defaults to /var/log>
> +#Init=/path/to/init-binary
> +#Pss=0

Hmm, so in systemd so far we tried to avoid abbreviations like this in
exported identifiers. So I'd really prefer if we could use "Frequency"
instead of "Freq" here. Abbreviations and acronyms raise the bar for

It's not to say we'd never export abbreviations/acronyms anywhere in
systemd, but if we do, then they must be very very well established...

Otherwise looks good. 


Lennart Poettering - Red Hat, Inc.

More information about the systemd-devel mailing list