[systemd-devel] [PATCH] Fix the race in deserialization.

Oleksii Shevchuk alxchk at gmail.com
Wed Feb 13 14:49:26 PST 2013

unit_notify is fired in deserelization code (particulary in
service_set_state). Units passed in random order, and there is possibility,
that unit with StopWhenUnneeded=yes passed before it actual dependecies. In
that case unit will be stopped as unneeded, because deps in UNIT_INACTIVE state

So, reuse similar logic (unit.c:1421) to avoid this race
 src/core/unit.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/core/unit.c b/src/core/unit.c
index f7d00b6..360da07 100644
--- a/src/core/unit.c
+++ b/src/core/unit.c
@@ -1497,7 +1497,8 @@ void unit_notify(Unit *u, UnitActiveState os, UnitActiveState ns, bool reload_su
         /* Maybe we finished startup and are now ready for being
          * stopped because unneeded? */
-        unit_check_unneeded(u);
+        if (u->manager->n_reloading <= 0)
+                unit_check_unneeded(u);

More information about the systemd-devel mailing list